fix: Missing orphanRemoval: true on non-nullable OneToMany relation…

…ships
roadiz · Mar 18, 2024 · b7bf6ed · b7bf6ed
1 parent 01e89d7
commit b7bf6ed
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 5 deletions.
diff --git a/src/Entity/CustomForm.php b/src/Entity/CustomForm.php
@@ -108,7 +108,12 @@ class CustomForm extends AbstractDateTimed
      * @var Collection<int, CustomFormField>
      */
     #[
-        ORM\OneToMany(mappedBy: "customForm", targetEntity: CustomFormField::class, cascade: ["ALL"]),
+        ORM\OneToMany(
+            mappedBy: "customForm",
+            targetEntity: CustomFormField::class,
+            cascade: ["ALL"],
+            orphanRemoval: true
+        ),
         ORM\OrderBy(["position" => "ASC"]),
         Serializer\Groups(["custom_form"]),
         SymfonySerializer\Groups(["custom_form"]),
@@ -123,7 +128,8 @@ class CustomForm extends AbstractDateTimed
         ORM\OneToMany(
             mappedBy: "customForm",
             targetEntity: CustomFormAnswer::class,
-            cascade: ["ALL"]
+            cascade: ["ALL"],
+            orphanRemoval: true
         ),
         Serializer\Exclude,
         SymfonySerializer\Ignore

diff --git a/src/Entity/CustomFormAnswer.php b/src/Entity/CustomFormAnswer.php
@@ -44,7 +44,8 @@ class CustomFormAnswer extends AbstractEntity
         ORM\OneToMany(
             mappedBy: "customFormAnswer",
             targetEntity: CustomFormFieldAttribute::class,
-            cascade: ["ALL"]
+            cascade: ["ALL"],
+            orphanRemoval: true
         ),
         Serializer\Groups(["custom_form_answer"]),
         SymfonySerializer\Groups(["custom_form_answer"])

diff --git a/src/Entity/NodeType.php b/src/Entity/NodeType.php
@@ -132,7 +132,12 @@ class NodeType extends AbstractEntity implements NodeTypeInterface
      * @var Collection<int, NodeTypeField>
      */
     #[
-        ORM\OneToMany(mappedBy: "nodeType", targetEntity: NodeTypeField::class, cascade: ["all"]),
+        ORM\OneToMany(
+            mappedBy: "nodeType",
+            targetEntity: NodeTypeField::class,
+            cascade: ["all"],
+            orphanRemoval: true
+        ),
         ORM\OrderBy(["position" => "ASC"]),
         Serializer\Groups(["node_type"]),
         SymfonySerializer\Groups(["node_type"]),

diff --git a/src/Model/AttributeGroupTrait.php b/src/Model/AttributeGroupTrait.php
@@ -40,7 +40,12 @@ trait AttributeGroupTrait
      * @var Collection<int, AttributeGroupTranslationInterface>
      */
     #[
-        ORM\OneToMany(mappedBy: "attributeGroup", targetEntity: AttributeGroupTranslationInterface::class, cascade: ["all"]),
+        ORM\OneToMany(
+            mappedBy: "attributeGroup",
+            targetEntity: AttributeGroupTranslationInterface::class,
+            cascade: ["all"],
+            orphanRemoval: true
+        ),
         Serializer\Groups(["attribute_group", "attribute", "node", "nodes_sources"]),
         Serializer\Type("ArrayCollection<RZ\Roadiz\CoreBundle\Model\AttributeGroupTranslationInterface>"),
         Serializer\Accessor(getter: "getAttributeGroupTranslations", setter: "setAttributeGroupTranslations")