Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support for Strings with single quote delimiters" #23

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

roadrunner1776
Copy link
Owner

Reverts #22

Causes display problems with various strings, for example:
Magik> write("Doesn't understand")

Also, some display issues within the method finder/class browser

@ReinhardHahn
Copy link
Contributor

ReinhardHahn commented Sep 10, 2021

Hello @roadrunner1776,

the problems with CB I didn't see yet. Could you please add some information on them - if they are reproducable?

The problem with output-texts containing single ' characters, I had seen already before, but I didn't regard it as serious. That is an issue, which has been existing with the EMACS delived with SW 4.x already and which has an easy workaround (see issue #24). The solution #22 just increases its impact. But is that really a reason not to implement this solution?

Yes, of course, it is a quantitative problem. Single ' characters occur much more frequently in the English language thatn single " characters. But nevertheless: the workaround is easy.

See also my discussion at the and of Issue #25

Thanks
Reinhard

@roadrunner1776 roadrunner1776 deleted the revert-22-support_for_single_quote_strings branch May 10, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants