Move to non-forked vst3-sys crate#236
Open
seandavies555 wants to merge 1 commit intorobbert-vdh:masterfrom
Open
Move to non-forked vst3-sys crate#236seandavies555 wants to merge 1 commit intorobbert-vdh:masterfrom
seandavies555 wants to merge 1 commit intorobbert-vdh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the forked version of vst3-sys was used, due to an extra fix being implemented on the specified branch. However this has now been fixed in the main repo.
Using the forked branch means that we don't get some other fixes that were made in the main crate when using nih-plug, this one in particular would be useful to have as currently cargo deny complains about the license formatting.
In any case it seems simpler to move over to the main repo rather than maintaining a separate fork.