Fix egui window scaling on Retina displays#247
Closed
SpruceCloud wants to merge 1 commit intorobbert-vdh:masterfrom
Closed
Fix egui window scaling on Retina displays#247SpruceCloud wants to merge 1 commit intorobbert-vdh:masterfrom
SpruceCloud wants to merge 1 commit intorobbert-vdh:masterfrom
Conversation
Convert logical pixels to physical pixels when resizing the window by multiplying by pixels_per_point(). Fixes issue #245 where the egui content would shrink to 1/4 size on macOS Retina displays when dragging the resize handle.
Contributor
|
Once #240 is merged, then this issue will be resolved too. I went ahead and added this fix to my 3rd party nih-plug integration. |
Author
|
I am closing this PR, since @BillyDM 's changes will contain the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Retina displays, when clicking the draggable element, the UI starts displaying in the lower left part of the window (1/4 of the size).
Convert logical pixels to physical pixels when resizing the window by multiplying by pixels_per_point(). Fixes issue #245 where the egui content would shrink to 1/4 size on macOS Retina displays when dragging the resize handle.
Unfortunately, I haven't tested the fix on Windows or Linux.