Skip to content

small adjustment to the timer behavior in the httpcluster retry loop #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robbyt merged 1 commit into from
Feb 6, 2026
Merged

small adjustment to the timer behavior in the httpcluster retry loop #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions runnables/httpcluster/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,17 @@ func (r *Runner) waitForIsRunning(
) bool {
ctx, cancel := context.WithTimeout(ctx, timeout)
defer cancel()
initialRetry := 5 * time.Millisecond
retryDelay := 5 * time.Millisecond
maxRetry := 1 * time.Second

timer := time.NewTimer(retryDelay)
defer timer.Stop()

for {
select {
case <-ctx.Done():
return false
case <-time.After(initialRetry):
case <-timer.C:
if server.IsRunning() {
return true
}
Expand All @@ -147,8 +150,8 @@ func (r *Runner) waitForIsRunning(
return false
}

// Exponentially increase the backoff delay
initialRetry = min(time.Duration(float64(initialRetry)*1.5), maxRetry)
retryDelay = min(time.Duration(float64(retryDelay)*1.5), maxRetry)
timer.Reset(retryDelay)
}
}
}
Expand Down