added onShowing, onShown, onClosing, onClosed prop events #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These events may be used in ui modifications while showing and hiding the notification.
added onShowing, onShown, onClosing, onClosed to README
onClosed will be fired with a parameter that informs if notification is being closed just to show again, in my case, I was hiding notification in onClosed event, but in case that it will be shown again, it should not be removed.
robcalcroft
reviewed
Sep 14, 2018
robcalcroft
reviewed
Sep 14, 2018
|
@murat-mehmet |
|
@murat-mehmet if you can resolve the conflicts I can merge |
|
@robcalcroft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These events may be used in ui modifications while showing and hiding the notification.