Skip to content

Refactor ViewFile to flatten control flow with helper extraction and add fuzzy match notifications #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
robch wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor ViewFile to flatten control flow with helper extraction and add fuzzy match notifications #98

robch wants to merge 3 commits into from

Conversation

@robch
Copy link
Owner

@robch robch commented Jan 17, 2026

Changes

  • Extracted ViewExistingFile helper to centralize file processing logic
  • Flattened control flow: fuzzy matching logic now at top level (zero extra indentation)
  • Added fuzzy match notifications visible to AI when path resolution occurs
  • Updated coding guidelines (Section 16) with helper extraction pattern

Benefits

  • Both code paths (direct and fuzzy) visible at same indentation level
  • Processing logic reused by both paths
  • Clearer separation of concerns: ViewFile = routing, ViewExistingFile = processing
  • Demonstrates the pattern documented in updated coding guidelines

Testing

  • Fuzzy match with notification ?
  • File not found error ?
  • Normal file access ?
  • All filters and features work correctly ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robch