fix: fix hardcoded mouse browsing background 修正寫死的滑鼠瀏覽底色 #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant issue: robertabcd#18 The support for customizing mouse browsing background was dropped in 8618472 "Refactor out easy reading and rendering". The functionality is reimplemented with the use of a new CSS variable --highlightBG. * src/js/: * term_buf.js: * Export termColors[] for the value of --highlightBG * term_view.js: * Add TermView.prototype.updateHighlightColor() to set up the CSS variable --highlightBG * Invoked by: * term_view.js TermView() * pttchrome.js App.prototype.onPrefChange() case 'mouseBrowsingHighlightColor' * Drop the unnecessary redraw() * src/css/color.css: * Add styling of class .hl * src/components/Row/LinkSegmentBuilder.js: * class LinkSegmentBuilder build(): * Set CSS class .hl instead of hardcoded BG color class .b2
IepIweidieng
force-pushed
the
fix/mouse-browsing-bg
branch
from
6738730 to
b3f7c90
Compare
IepIweidieng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #18
The support for customizing mouse browsing background was dropped in the following commit:
對自訂滑鼠瀏覽底色的支援已於下列 commit 中移除：
The functionality is reimplemented with the use of a new CSS variable
--highlightBG.該功能已以使用新 CSS 變數
--highlightBG重新實作。Screenshots