Improve configuration #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 62b1e1f519b704d14f2d4e4fed555d6da6edd26a.
robinovitch61
added a commit
that referenced
this pull request
Nov 15, 2023
Improvements: - make relevant options boolean flags rather than true/false strings - make relevant options ints rather than strings - simplify implementation of cobra + viper cli > env var > config file > default val priority - better example `~/.wander.yaml` in README Breaking changes: - fully remove `wander_addr` and `wander_token` options, replacing with `nomad_addr` and `nomad_token` - cli option boolean usage like `--compact-header true` must be replaced with `--compact-header=true` or just `--compact-header`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
~/.wander.yamlin READMEBreaking changes:
wander_addrandwander_tokenoptions, replacing withnomad_addrandnomad_token--compact-header truemust be replaced with--compact-header=trueor just--compact-header