Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exec functionality #113

Merged
merged 15 commits into from
Dec 1, 2023
Merged

Improve exec functionality #113

merged 15 commits into from
Dec 1, 2023

Conversation

robinovitch61
Copy link
Owner

@robinovitch61 robinovitch61 commented Dec 1, 2023 •
edited
Loading

Fixes #107

This is a big change that does the following:

  • replaces the bespoke exec implementation with an impl inspired from the nomad cli, using the client directly
  • add a wander exec command
  • therefore tls is supported
  • improves general exec experience (can move cursor, does not strip ansi escape sequences, etc)
  • BREAKAGE: exec with wander serve breaks. Unfortunately with this impl, tea.ExecProcess is used, which is currently unsupported in wish ssh apps

@robinovitch61 robinovitch61 marked this pull request as ready for review December 1, 2023 20:02
@robinovitch61 robinovitch61 merged commit 312277a into next Dec 1, 2023
2 checks passed
@robinovitch61 robinovitch61 deleted the 107-exec branch December 1, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robinovitch61