[feat] Add nomad system garbage collection #135
Conversation
|
Good proof of concept, but I don't think this should be added as-is. Many people won't want to garbage collect accidentally for one reason or another, and it doesn't really make sense to be able to do it from any page. It's also fairly easy to type |
|
Meta: my preference is to have discussions around features and design on issues rather than in pull requests. If you find yourself writing code implementing something that there's not yet an issue for, please open an issue for it :) |
| @@ -510,6 +510,23 @@ func (m *Model) handleKeyMsg(msg tea.KeyMsg) tea.Cmd { | |||
| } | |||
| } | |||
|
|
|||
| case key.Matches(msg, keymap.KeyMap.GarbageCollect): | |||
| err := m.client.System().GarbageCollect() | |||
There was a problem hiding this comment.
If this action hangs for one reason or another, it will hang the whole wander app (unable to navigate, quit, etc). This is why wander runs async actions in Cmds, which run in bubbletea in non-deterministic order in goroutines outside the main application event loop. See https://github.com/charmbracelet/bubbletea/tree/master/tutorials/commands/ for details :)
There was a problem hiding this comment.
Got it. Will keep that in mind.
nomad-gc-wander.webm