generated from roboflow/template-python
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix external track ids #1364
Open
rolson24
wants to merge
7
commits into
roboflow:develop
Choose a base branch
from
rolson24:fix_external_track_ids
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix external track ids #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yea it is also related to #1320, sorry about that.
…On Wed, Jul 17, 2024 at 6:19 AM Piotr Skalski ***@***.***> wrote:
Hi @rolson24 <https://github.com/rolson24> 👋🏻, we have two issues
related to tracking that were submitted recently:
- #1355 <#1355>
- #1320 <#1320>
IS it related to both of them or only #1355
<#1355>?
—
Reply to this email directly, view it on GitHub
<#1364 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX2EJPCWDV7PAKR24CQNY2LZMZAKDAVCNFSM6AAAAABK5FT73OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSHE2TKOBVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
SkalskiP
requested changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix is for issue #1355. The tracker is skipping ID's for a few reasons. First off when the
minimum_consecutive_frames
is set to 1, each track gets assigned a new external id when it is created inactivate()
is called. This is an issue because not all of these tracks make it through the next frame where they get matched with a new detection andupdate()
gets called. That means we are assigning an external track id to tracks that never are real tracks. I fixed this by getting rid of the external track id assignment inactivate()
(except for the first frame of the video) and instead just using the external id assignment in theupdate()
function, which is how we do the assignment whenminimum_consecutive_frames > 1
.The second reason the tracker is skipping ID's is because in the
removed_duplicate_tracks()
function, there is an overlap threshold to determine if two tracks are the same. In the current release this threshold is set at 0.15 which is relatively high because two tracks could be passing by each other and if they overlap more than 85% one would get removed. I lowered the threshold to 0.05 to reduce this.Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
This fix was tested with this notebook
Here you can see that in the old version external id 4 was skipped, but in the new version its not
Output from old version:
Output from fixed version:
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs