Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported fix for premature CB initalisation #74

Merged

Conversation

yassiezar
Copy link
Contributor

@yassiezar yassiezar commented Nov 28, 2022

Porting over premature initialisation guard from #61

┆Issue is synchronized with this Jira Task by Unito

@yassiezar yassiezar force-pushed the fix-premature-cb-init branch from 15e4310 to 64196fb Compare November 28, 2022 17:01
@yassiezar yassiezar force-pushed the fix-premature-cb-init branch from 64196fb to 27eb026 Compare November 28, 2022 17:03
@pabloinigoblasco
Copy link
Collaborator

This is a great contribution because fix a know bug in smacc2 that was already fixed, but that was not synchronized in smacc1.

https://github.com/robosoft-ai/SMACC2/blob/ae6f3700b025df2f7d6edcccb3c42140b2de87bc/smacc2/src/smacc2/signal_detector.cpp#L269

@pabloinigoblasco pabloinigoblasco merged commit 616ab1c into robosoft-ai:noetic-devel Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants