Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrote pending tests - for review #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dklounge
Copy link
Contributor

@dklounge dklounge commented Jan 3, 2014

Could use your help in reviewing some of the specs I wrote for the pending tests. The class spec is bit messy. Basically, I struggled to get the auth && auth.persisted? block to work. Initially, I tried stubbing outside of the context block initially,

auth.stub(:persisted?).and_return true

but that had no impact on auth object created using auth_hash, so ended up writing things out and calling update_attributes directly. Your thoughts?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 333a861 on dklounge:authorisation_spec into 954af5d on afternoonrobot:master.

@robotmay
Copy link
Owner

robotmay commented Jan 3, 2014

Thanks for this @dklounge! I've only got time to leave this comment tonight but I'll take a look at this over the weekend :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants