-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for quaternions to GaussianMixture and related #82
Merged
claudiofantacci
merged 5 commits into
robotology:devel
from
xEnVrE:impl/gaussian_mixture_w_quaternion
Feb 18, 2020
Merged
Add support for quaternions to GaussianMixture and related #82
claudiofantacci
merged 5 commits into
robotology:devel
from
xEnVrE:impl/gaussian_mixture_w_quaternion
Feb 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiofantacci
requested changes
Feb 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes, then LGTM 🚀
82e5aca
to
8d1c55b
Compare
claudiofantacci
approved these changes
Feb 18, 2020
@xEnVrE, can you please resolve the conflicts? 😄 |
claudiofantacci
previously approved these changes
Feb 18, 2020
Yep! |
8d1c55b
to
64e1167
Compare
claudiofantacci
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within this PR:
GaussianMixture
and derived classes (Gaussian
andParticleSet
).test_Gaussian
CHANGELOG.md
Details
The most important change is done inside the class
GaussianMixture
where a new argumentuse_quaternion
is supported in the generic constructor. By default, the constructor assumes thatuse_quaternion = false
.The interpretation is the following:
use_quaternion == false
anddim_circular != 0
, then each circular component is treated as a component in the manifoldS1
, i.e. the circle. SinceGaussianMixture
, and derived, are mainly responsible for the storage, the mean circular components are stored as vectors inR^{dim_circular}
and the associated covariance matrices as matrices inR^{dim_circular x dim_circular}
. This is the default behavior that the library was already implementing.use_quaternion == true
anddim_circular != 0
, then each circular component is treated as a component in the manifoldS3
represented using a quaternion. Storage-wise, the mean associated with each quaternion is stored as a vector inR^4
(i.e. real and imaginary part of the quaternion) and the associated covariance matrix as a matrix inR^{3 x 3}
. Indeed, the uncertainty associated with the quaternion is best represented in the tangent space, i.e. rotation vectors, that can be treated asR^{3}
.