Set YCM_USE_CMAKE_NEXT to OFF by default to use upstream CMake's ExternalProject instead of YCM's fork #1674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, ycm-cmake-modules have been carrying on a patched version of CMake's ExternalProject module that made sure that it was never possible for ExternalProject to delete a source directory of a repo (the one contained in
robotology-superbuild/src/<package>
) if one had local modifications and it did not setYCM_EP_DEVEL_MODE_<package>
toON
. For more details, see:Unfortunately, the modification was never merged upstream, and it is not anymore possible for me to keep the forked ExternalProject version aligned with the CMake's upstream
ExternalProject
. So in this PR we setYCM_USE_CMAKE_NEXT
toOFF
to stop using YCM's ExternalProject module, and start using the regular CMake's ExternalProject.Fix #1671 .
Important
Before this PR the robotology-superbuild raised an error if you called
make update-all
orninja update-all
and there was repo with local modification withYCM_EP_DEVEL_MODE_<package>
set toOFF
. After this PR, instead the robotology-superbuild will discard the local modifications. To avoid losing data, never call theupdate-all
target if you have local modifications in a package and you did not setYCM_EP_DEVEL_MODE_<package>
toON
for that package.If you experience problem with the default setting of
YCM_USE_CMAKE_NEXT
set toOFF
, you can manually set it toON
to restore the behavior of the robotology-superbuild before August 2024. However, this option will be removed in January 2025.