Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set YCM_USE_CMAKE_NEXT to OFF by default to use upstream CMake's ExternalProject instead of YCM's fork #1674

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Jul 30, 2024

Historically, ycm-cmake-modules have been carrying on a patched version of CMake's ExternalProject module that made sure that it was never possible for ExternalProject to delete a source directory of a repo (the one contained in robotology-superbuild/src/<package>) if one had local modifications and it did not set YCM_EP_DEVEL_MODE_<package> to ON . For more details, see:

Unfortunately, the modification was never merged upstream, and it is not anymore possible for me to keep the forked ExternalProject version aligned with the CMake's upstream ExternalProject. So in this PR we set YCM_USE_CMAKE_NEXT to OFF to stop using YCM's ExternalProject module, and start using the regular CMake's ExternalProject.

Fix #1671 .

Important

Before this PR the robotology-superbuild raised an error if you called make update-all or ninja update-all and there was repo with local modification with YCM_EP_DEVEL_MODE_<package> set to OFF. After this PR, instead the robotology-superbuild will discard the local modifications. To avoid losing data, never call the update-all target if you have local modifications in a package and you did not set YCM_EP_DEVEL_MODE_<package> to ON for that package.

If you experience problem with the default setting of YCM_USE_CMAKE_NEXT set to OFF, you can manually set it to ON to restore the behavior of the robotology-superbuild before August 2024. However, this option will be removed in January 2025.

@traversaro traversaro changed the title Set YCM_USE_CMAKE_NEXT to OFF by default to use CMake's ExternalProject Set YCM_USE_CMAKE_NEXT to OFF by default to use upstream CMake's ExternalProject instead of YCM's fork Jul 30, 2024
@traversaro traversaro merged commit fc72e40 into master Aug 2, 2024
25 checks passed
@traversaro traversaro deleted the traversaro-patch-8 branch August 2, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 20.04 GitHub Actions CI with apt dependencies on GHA images (not vanilla docker) fails
1 participant