Cleanup FindOpenCV.cmake and deprecate OpenCV_LIBRARIES in favor of OpenCV_LIBS
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
changed the title
OpenCV_LIBRARIES in favor of OpenCV_LIBS
Nicogene
approved these changes
Nov 16, 2023
|
@pattacini we should adapt which repository uses |
Yes, definitely, but it's not for this distro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindOpenCV.cmakecontains a lot of legacy logic that is not useful for any OpenCV version >= 3, and that takes a lot of time iffind_package(OpenCV)is called in a system without OpenCV. This PR removes the legacy logic, and deprecated theFindOpenCV.cmakemodule YCM, as downstream users should be able to just use the regularOpenCVConfig.cmakeinstalled directly by CMake. As a consequence of this, downstream users should switch fromOpenCV_LIBRARIEStoOpenCV_LIBS.