Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YCMEPHelper: Set ExternalProject's BUILD_ALWAYS to ON to restore behaviour of old vendored YCM's ExternalProject #462

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

traversaro
Copy link
Member

Fix robotology/robotology-superbuild#1700 . To be honest, I have no idea how this ever worked, or how it was working for users that reported that it was working fine for them (@LoreMoretti). However, if we want that executing a target always re-compile the project, indeed the ExternalProject's BUILD_ALWAYS option is explicitly designed for that:

BUILD_ALWAYS

Enabling this option forces the build step to always be run. This can be the easiest way to robustly ensure that the external project's own build dependencies are evaluated rather than relying on the default success timestamp-based method. This option is not normally needed unless developers are expected to modify something the external project's build depends on in a way that is not detectable via the step target dependencies (e.g. SOURCE_DIR is used without a download method and developers might modify the sources in SOURCE_DIR).

Just to permit users that want to set BUILD_ALWAYS to OFF, the option is now also exposed by YCMEPHelper, but its default value there is ON, while the default value of BUILD_ALWAYS in ExternalProject is OFF.

@traversaro
Copy link
Member Author

I tested locally and this is working fine, let's merge to fix robotology/robotology-superbuild#1700 .

@traversaro traversaro merged commit 7ab923a into master Sep 5, 2024
18 checks passed
@traversaro traversaro deleted the fixbuildafterupdate branch September 5, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ninja in the build directory of the superbuild does not recompile all the projects
1 participant