Add command line script#73
Conversation
- make ufoLib2 an optional dependency - attempt to fall back to defcon if ufoLib2 is not installed - output status messages when running the script
|
Can we add an optional command line option to choose between |
|
Ugh, tried to avoid messing with the args parser, but okay, I guess it's time to grow up. I'll try. 😄 |
|
@rimas-kudelis steal from here: #35 (comment) |
|
Yep, I'm looking at it, but it won't be just stealing. That command requires that the input font is TTF/OTF, for example, and extractor supports more formats than just that. I'll add the output format argument from that script though. I'm on it already. |
|
@benkiel, done. I could still add even more options, like maybe one for the destination directory. |
| """ | ||
| Extract one ore more fonts to UFO. Installed as command line script | ||
| `extractufo`. | ||
|
|
||
| Usage: extractufo font [font ...] | ||
| """ |
There was a problem hiding this comment.
Also, not sure if it makes sense to keep this comment now that we're using the argument parser.
|
Ouch, it seems defcon doesn't support the Also, is there any quick kind of a test I could add, assuming I know very little about Python and pytest? |
|
@rimas-kudelis Looking at the code for overwrite in ufoLib2, I would say we should just remove the overwrite option. If you want to keep it, would say "This will not work if backend is |
| ) | ||
| parser.add_argument('FONT_FILE', help='Input font path', nargs="+") | ||
| parser.add_argument('-m', '--ufo-module', choices=['ufoLib2', 'defcon'], help='Select the default library for writing UFOs (default: autodetect, prefer ufoLib2)') | ||
| parser.add_argument('-z', '--zip', action="store_true", help="Output UFO ZIP") |
There was a problem hiding this comment.
Hm, "UFO ZIP" is actually how the specification calls it. :)
There was a problem hiding this comment.
Cool. I can't remember, and I am used to thinking UFOZ, but fine with UFO ZIP
There was a problem hiding this comment.
From https://unifiedfontobject.org/versions/ufo3/#storage-formats:
UFO has two possible storage formats. The first, “UFO Package”, is a multi-file, file system directory structure. The second, “UFO ZIP”, is a ZIP archive containing the same directory structure as defined for UFO Package.
I'll leave this as-is then.
Lib/extractor/__init__.py
Outdated
| ufo = Font() | ||
| extractUFO(font_path, ufo) | ||
| try: | ||
| ufo.save(ufo_path, overwrite=args.overwrite, structure=structure) |
There was a problem hiding this comment.
could just drop overwrite here for simplicity
There was a problem hiding this comment.
Okay, I've removed the option, and added an explicit check for file/dir existence. If it exists, that input file will not be converted.
I reckon that's better than having two different scenarios, right?
Hm, maybe I should make a PR for defcon adding this option though... 😆
|
Thank you! Going to push this out as a new release |
|
I think maybe we should update the readme first. |
|
Thanks @rimas-kudelis for the awesome job! The parent folder part in my script is just to organise the files easier, in the end I end up not using that option at all 😂 |
|
@NightFurySL2001, thank you for your script as well! As you see, I took some inspiration from it. :) BTW I had some doubts about whether I should accept an unlimited list of input files or instead accept only one input file and allow specifying output file name like you did, but I guess I was too lazy to change that bit. But I do think that maybe your approach is better, since looping could have easily be done externally in the shell. Oh well... :) |
4 participants
This rebases and #35 from master and adds some small improvements over it, namely:
ufoLib2from hard to an optional dependencydefconifufoLib2is not installedFixes #35, fixes #60 (although the script is still not as fancy as the one suggested in #60).