Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate and document guideline.py #809

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Annotate and document guideline.py #809

merged 9 commits into from
Dec 6, 2024

Conversation

knutnergaard
Copy link
Contributor

@knutnergaard knutnergaard commented Dec 6, 2024 •
edited
Loading

No description provided.

@knutnergaard knutnergaard changed the title Solve mypy errors. Annotate and document guideline.py Dec 6, 2024
@knutnergaard knutnergaard reopened this Dec 6, 2024
@knutnergaard knutnergaard marked this pull request as draft December 6, 2024 07:58
@knutnergaard knutnergaard mentioned this pull request Dec 6, 2024
Open
@knutnergaard
Copy link
Contributor Author

knutnergaard commented Dec 6, 2024 •
edited
Loading

@benkiel The documentation for BaseGuideline._get_index declares that the return type should be int, while the actual method also returns None if no font or glyph is set for the guideline. Should the return type be optional?

@benkiel
Copy link
Member

benkiel commented Dec 6, 2024

Yes, should be int or None

@knutnergaard knutnergaard marked this pull request as ready for review December 6, 2024 16:46
@benkiel benkiel merged commit af7ca96 into robotools:v1 Dec 6, 2024
@knutnergaard knutnergaard deleted the guideline branch December 7, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benkiel benkiel benkiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knutnergaard @benkiel