-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add option struct to optimize parameter transfer #112
Conversation
Signed-off-by: Extreme <1403539044@qq.com>
Very cool! This will have conflict with a few of the open PRs as they are all new feature flags. Will need a good rebase after PRs 109, 110, and 113 are merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Forget-C! This is a great improvement that has been long overdue. Just a tiny nit on naming but otherwise LGTM.
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
Thank you for your advice. I modified the naming and merged with the master branch |
Thanks @Forget-C! |
Add option struct to optimize parameter transfer
Affect user experience: false