Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add option struct to optimize parameter transfer #112

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

Forget-C
Copy link
Contributor

Add option struct to optimize parameter transfer

Affect user experience: false

Signed-off-by: Extreme <1403539044@qq.com>
@isaacnboyd
Copy link
Contributor

Very cool! This will have conflict with a few of the open PRs as they are all new feature flags. Will need a good rebase after PRs 109, 110, and 113 are merged.

Copy link
Owner

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Forget-C! This is a great improvement that has been long overdue. Just a tiny nit on naming but otherwise LGTM.

Forget-C and others added 4 commits January 22, 2024 12:54
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
@Forget-C
Copy link
Contributor Author

Thanks @Forget-C! This is a great improvement that has been long overdue. Just a tiny nit on naming but otherwise LGTM.

Thank you for your advice. I modified the naming and merged with the master branch

@robscott robscott merged commit 582bb85 into robscott:main Jan 23, 2024
3 checks passed
@robscott
Copy link
Owner

Thanks @Forget-C!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants