fixup! WiP

CHANGELOG.md

@@ -14,6 +14,8 @@
    - ⚠️ `neo4j::error::ServerError::new(...)` has been removed.  
      User-code should not need to create arbitrary `ServerError`s.
      In return, `ServerError` now implements `Clone`.
+ - Add support for Bolt 5.8 (home database resolution cache)
+   - Includes an optimization where the driver uses a home/default database cache to perform optimistic routing under certain circumstances, saving a full round trip. See the [PR description](https://github.com/robsdedude/neo4j-rust-driver/pull/28) for more details.
  - Add support for bolt handshake manifest v1.
 
 **🔧 Fixes**

neo4j/src/driver/config.rs

@@ -795,7 +795,7 @@ impl ConnectionConfig {
                 }
             }
             Some(query) => {
-                if query == "" {
+                if query.is_empty() {
                     Some(HashMap::new())
                 } else {
                     if !routing {

testkit_backend/src/testkit_backend/responses.rs

@@ -129,6 +129,14 @@ fn get_plain_skipped_tests() -> &'static HashMap<&'static str, &'static str> {
                 "stub.summary.test_summary.TestSummaryNotifications4x4.test_no_notifications",
                 "An empty list is returned when there are no notifications",
             ),
+            (
+                "stub.driver_parameters.test_connection_acquisition_timeout_ms.TestConnectionAcquisitionTimeoutMs.test_does_not_encompass_router_route_response",
+                "Pending driver unification: only some drivers consider a single connection acquisition timeout for all operations on acquisition (like fetching routing table) and some consider a separate timeout for each operation",
+            ),
+            (
+                "stub.driver_parameters.test_connection_acquisition_timeout_ms.TestConnectionAcquisitionTimeoutMs.test_router_handshake_has_own_timeout_in_time",
+                "Pending driver unification: only some drivers consider a single connection acquisition timeout for all operations on acquisition (like fetching routing table) and some consider a separate timeout for each operation",
+            ),
             (
                 "neo4j.test_summary.TestSummary.test_no_notification_info",
                 "An empty list is returned when there are no notifications",