Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP build basic-webserver 0.11 release #7241

Closed
wants to merge 4 commits into from
Closed

Conversation

Anton-4
Copy link
Collaborator

@Anton-4 Anton-4 commented Nov 22, 2024

No description provided.

@Anton-4
Copy link
Collaborator Author

Anton-4 commented Nov 25, 2024

Adding default-features=false to sqlite3-sys = { version = "0.17.0", features = ["bundled"] } (like in the previous release under the hood) brings me to a new but similar error:

   Compiling host v0.0.1 (/home/username/gitrepos/roc/basic-webserver/crates/roc_host_lib)
error: linking with `rust-lld` failed: exit status: 1
  |
  = note: LC_ALL="C" PATH=...
  = note: rust-lld: error: undefined symbol: sqlite3_finalize
          >>> referenced by host.5c75dddb0be1e17b-cgu.0
          >>>               /home/username/gitrepos/roc/basic-webserver/target/aarch64-unknown-linux-musl/release/deps/host-364a10f93a151585.host.5c75dddb0be1e17b-cgu.0.rcgu.o:(core::ptr::drop_in_place$LT$roc_host..roc..SqliteStatement$GT$::hd13e2f99c9f6ea54)
          

error: could not compile `roc_host_bin` (bin "host") due to 1 previous error

@Anton-4
Copy link
Collaborator Author

Anton-4 commented Nov 26, 2024

A vital piece of info related to the sqlite3_finalize error; when I modified build.roc to use cagro build without --release and looked at the failing linking command, I saw roc/basic-webserver/target/aarch64-unknown-linux-musl/debug/build/sqlite3-src-864b501083279ab2/out. The interesting thing is, this folder does not exist! There is a folder like that with a different hash but without the libsqlite3.a file that should be there. This could potentially be a cargo bug. Anyway, I was able to produce a folder with that sha by modifying basic-webserver 0.9.0 so it uses the same version of libsqlite3-sys. Next, I'm just going to try copying this folder and see if that fixes it 😄 . If not, I see no other option then reverting roc-lang/basic-webserver#61 .

EDIT: I was looking at the wrong folder

@Anton-4
Copy link
Collaborator Author

Anton-4 commented Nov 28, 2024

The undefined symbol: sqlite3_finalize error is also reproducible on linux x64, if you change sqlite3-sys = { version = "0.17.0", features = ["bundled"] } to sqlite3-sys = { version = "0.17.0", features = ["bundled"], default-features = false}.

Signed-off-by: Anton-4 <17049058+Anton-4@users.noreply.github.com>
@Anton-4 Anton-4 changed the title WIP build basic-webserver 0.10 release WIP build basic-webserver 0.11 release Dec 28, 2024
Signed-off-by: Anton-4 <17049058+Anton-4@users.noreply.github.com>
Signed-off-by: Anton-4 <17049058+Anton-4@users.noreply.github.com>
Copy link

Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked Closed are not deleted, so no matter what, the PR will still be right here in the repo. You can always access it and reopen it anytime you like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant