Align PNC Apply Pattern with Expr #7490
Conversation
| @@ -108,6 +110,37 @@ where | |||
| } | |||
| } | |||
|
|
|||
| pub trait FieldValue { | |||
There was a problem hiding this comment.
It's not immediately obvious to me what this does, maybe add a doc comment?
| Mapper(&'a Loc<Field>), | ||
| } | ||
|
|
||
| pub(crate) fn fmt_record_like<'a, 'b: 'a, Field, ToSpacesAround>( |
There was a problem hiding this comment.
Eventually, it might be nice to use this for other types of collections like lists. I don't think we need to make any changes right now, but food for thought for the future.
| @@ -1702,7 +1678,13 @@ fn fmt_when<'a>( | |||
|
|
|||
| buf.spaces(1); | |||
|
|
|||
| fmt_pattern(buf, &pattern.value, indent + INDENT, Parens::NotNeeded); | |||
| let lifted = pattern_lift_spaces(buf.text.bump(), &pattern.value); | |||
|
|
|||
There was a problem hiding this comment.
Is this missing a call to format lifted.after?
| @@ -1715,7 +1697,11 @@ fn fmt_when<'a>( | |||
|
|
|||
| buf.indent(indent + INDENT); | |||
| let line_indent = buf.cur_line_indent(); | |||
| buf.push_str(" ->"); | |||
| if buf.ends_with_space() || buf.ends_with_newline() { | |||
There was a problem hiding this comment.
Pro tip: you should be able to just use buf.ensure_ends_with_whitespace(), followed by buf.push_str("->")
| /// Can only occur inside of a RecordDestructure | ||
| OptionalField(&'a str, &'a Loc<Expr<'a>>), | ||
| RecordDestructure(Collection<'a, Loc<AssignedField<'a, Pattern<'a>>>>), | ||
| ExprWrapped(Expr<'a>), |
|
Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked |
This doesn't actually solve #7486 but it aligns things so that it can be fixed. That issue is a little contentious and based on looking at the output and not liking what it looks like without considering the original source (that source is just completely artificial and not helpful).
I think that if #7470 gets merged with this, the fuzzer will be much more stable.