Refine event handling in android backend (#98) #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 2 new enums: agent.StateEvent and agent.FailureEvent. We'll use them instead of string code when emitting events from agent to model, to ensure that model won't have an implicit dependency on some magic strings. - refreshState() generates StateEvent. No matter what even we got from kotlin, we always check actual state we have right now and generate event according to that state. This way we can be sure that events received by model will be consistent with the state that it observes when calling receiverIsAlive/senderIsAlive. - onError() translates error codes from kotlin to higher-level failure event codes. Model translates these error codes to localized error messages. UI shows these messages.
Izchomatik
requested changes
Feb 8, 2025
| @@ -2,6 +2,18 @@ import 'package:event/event.dart'; | |||
|
|
|||
| import 'android_bridge.g.dart'; | |||
|
|
|||
| /// Event codes for state change events. | |||
| enum StateEvent { | |||
There was a problem hiding this comment.
When you are ok with this - I would like to have the event enums as two additional separate files: state_event.dart and failure_event.dart
|
|
||
| await refreshState(); | ||
|
|
||
| switch (errorCode) { |
There was a problem hiding this comment.
It would be nice to add a default clause as well (something like an unspecified error or something)
Izchomatik
added
needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 new enums: agent.StateEvent and agent.FailureEvent.
We'll use them instead of string code when emitting events
from agent to model, to ensure that model won't have an
implicit dependency on some magic strings.
refreshState() generates StateEvent. No matter what even we got
from kotlin, we always check actual state we have right now and
generate event according to that state. This way we can be sure
that events received by model will be consistent with the state
that it observes when calling receiverIsAlive/senderIsAlive.
onError() translates error codes from kotlin to higher-level
failure event codes. Model translates these error codes to
localized error messages. UI shows these messages.