Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rewrite Subcommand.run using Kernel.spawn #109

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: rewrite Subcommand.run using Kernel.spawn #109

wants to merge 3 commits into from

Commits on Nov 11, 2021

  1. fix: rewrite Subcommand.run using Kernel.spawn 

    The current implementation was doing fork/exec by hand because it
had been created under ruby 1.8, which did not have spawn. It makes
zero sense nowadays, where there exists a multiplatform implementation
in the language itself.
    @doudou
    doudou committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    8c64813 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. fix: auto-correct Layout/OddElseLayout 

    This error started appearing in a new version of rubocop. It is
auto-correctable, so auto-correct it
    @doudou
    doudou committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    b713882 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. fix: do not close stdin, older CMake versions fail when it is

    @doudou
    doudou committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    f1d916c View commit details
    Browse the repository at this point in the history