Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run github workflows on ruby 3.0 #127

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

run github workflows on ruby 3.0 #127

wants to merge 7 commits into from

Conversation

g-arjones
Copy link
Contributor

@g-arjones g-arjones commented Feb 10, 2023 •
edited
Loading

@g-arjones g-arjones force-pushed the run_workflows_on_ruby3 branch 8 times, most recently from a8e81d5 to 6cd2b76 Compare February 10, 2023 21:31
@doudou
Copy link
Member

doudou commented Feb 10, 2023

Do you know if there's a way to allow some configurations to fail ? That would be most helpful ...

While we're at it, I would add 3.1 and 3.2 too ...

@g-arjones g-arjones force-pushed the run_workflows_on_ruby3 branch 3 times, most recently from 5ae3841 to 5a28ea9 Compare February 11, 2023 00:23
@g-arjones
Copy link
Contributor Author

Do you know if there's a way to allow some configurations to fail ?

Not that I know of. There was this issue/feature request but it was closed as not planned on Dec 22, 2022.

While we're at it, I would add 3.1 and 3.2 too ...

I tried and they were failing so I left them to be added n the future.

@doudou
Copy link
Member

doudou commented Sep 8, 2024

Hey ... FYI ... I hijacked this issue to solve a git test problem. My objective is to have pass tests and merge.

g-arjones and others added 5 commits September 8, 2024 15:47
@g-arjones @doudou
run github workflows on ruby 3.0
99cf0e3
@g-arjones @doudou
use new flexmock syntax
209d539
@doudou
fix: remove unneeded version guard on webrick
0be0e8d
@doudou
fix: add version constraint on flexmock
f76aa8a
@doudou
fix: allow the file protocol during git tests
15f0c3b 
Unfortunately, the simple way that is using Git.default_options
does not work for recursive initialization of submodules (since
the config is not propagated to the submodules themselves)
@g-arjones
Copy link
Contributor Author

Cool.. Thank you for that.

@g-arjones
Copy link
Contributor Author

g-arjones commented Sep 9, 2024 •
edited
Loading

By the way, you mentioned you wanted to keep support for Ruby 2.5. Don't you want to add that to the ruby-version matrix in that case?

@doudou
Copy link
Member

doudou commented Sep 9, 2024

By the way, you mentioned you wanted to keep support for Ruby 2.5. Don't you want to add that to the ruby-version matrix in that case?

Good catch, re-added.

@g-arjones
Copy link
Contributor Author

👍

@g-arjones
Copy link
Contributor Author

@doudou Can we merge this?

@chhtz chhtz mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doudou doudou doudou approved these changes

Assignees

@doudou doudou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-arjones @doudou