Acceleration #5
Open
Acceleration #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2016 12:40
…en-controldev into acceleration Conflicts: tasks/GenericRawToMotion2D.cpp
| } | ||
|
|
||
| /* handle the translational part */ | ||
| uint8_t stop_translation_button = rcmd.buttonValue[_stop_translation_button.get()]; |
There was a problem hiding this comment.
I believe that not every input device necessarily provides buttons, so this options should be optional and deactivated on default.
There was a problem hiding this comment.
yes, that's why they are just used with acceleration mode enabled. Maybe it's a good idea to check the length of the button vector before?
added 7 commits
April 18, 2016 16:36
…ogen-controldev into acceleration Conflicts: tasks/GenericRawToMotion2D.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the acceleration mode enabled, one can accelerate or decelerate with the analogue inputs, which is better suited for controlling comparably slow walking robots or when moving over great disrances