-
-
Notifications
You must be signed in to change notification settings - Fork 70
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
7b72ac6
commit aa94d57
Showing
2 changed files
with
5 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa94d57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance to tag each new release with number only? I see libpsl-0.8.1 instead of 0.8.1 in tags which causes trouble to our tracking system. I don't care if it's intended for Debian, but please change back to normal ways.
Thanks.
aa94d57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally do not care much, the tag ( and format) is mainly for package maintainers.
AFAIR, someone asked me to change it from number only to libpsl- :-)
Couldn't find the request so far (it was either Daniel Kahn Gilmor (Debian) or Dagobert Michelsen (Solaris)). I didn't look at many other libraries... what is the common format ? I would like to go with that.
aa94d57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Common ways:
v0.8.1
Or
0.8.1
aa94d57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cicku I am going to release 0.9.0. Having a look at curl, c-ares or gnutls (C libraries): they use the tagging convention 'name-x_y_z', e.g. cares-1_0_1. Your tracking should be able to handle that.
Also, one of the closed issues asked me to change from x.y.z to libpsl-x.y.z because x.y.z is bad for packagers :-) So I stay with that convention.
aa94d57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's bullshit, no offense.
In the past Github treated these tags and pushed tarball name to libpsl-libpsl-0.9.0, kinda dumb name, now github realizes the issue, and starts promoting release functionality.
I don't have issues now, because releases page contains libpsl-$VER.(tar.gz|zip).
Sorry for the noise 😂
aa94d57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-) Thanks, I didn't know about this 'interesting' naming on github.