Skip to content

Beat That Submission - Hai Liang#554

Open
HLTan1 wants to merge 1 commit intorocketacademy:mainfrom
HLTan1:main
Open

Beat That Submission - Hai Liang#554
HLTan1 wants to merge 1 commit intorocketacademy:mainfrom
HLTan1:main

Conversation

@HLTan1
Copy link

@HLTan1 HLTan1 commented Dec 6, 2023

final version, forgot to commit previous versions at all..

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment?
4 hours on-off

Please fill in one error and/or error message you received while working on this assignment.
fatal: not a git repository. not sure how to fix this, manually pasted code into git for now. coding error wise just a bunch of undefines that were resolved along the way.

What part of the assignment did you spend the most time on?
roughly equal for all except towards the end where game sequence was messed up after "submit to play again". had to reposition reset() and thoroughly reset all global variables.

Comfort Level (1-5):
3/5

Completeness Level (1-5):
2/5

What did you think of this deliverable?
Seems shaky and doesn't account for many different scenarios of wrong user input.

Is there anything in this code that you feel pleased about?
No.

What's one aspect of your code you would like specific, elaborate feedback on?
In a project like this where there are so many game states to jump into, is game state changing the ideal way to trigger the different conditions? Or is there a better way? It is still manageable here since we are only triggering one game state at a time, but if it is required to fulfill multiple game states at once, then is this still the ideal method? Seems like it will become very messy across the code if we start manually checking multiple states as conditions.

final version, forgot to commit previous versions at all..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant