Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
2.5
Please fill in one error and/or error message you received while working on this assignment.
my p1WinCounts and p2WinCounts were undefined at first. this is because i didnt initialize it to 0. instead of var p1WinCounts =0, i wrote let p1WinCounts;
so when i tried to +1 to the count, it returned undefined and i couldnt figure out why for a while until i dumped everything into chatgpt and asked.
What part of the assignment did you spend the most time on?
getting used to arrays.
Comfort Level (1-5):
3
Completeness Level (1-5):
3
What did you think of this deliverable?
fun to work on!
Is there anything in this code that you feel pleased about?
i tried using more helper functions this time around.
What's one aspect of your code you would like specific, elaborate feedback on?
how to shorten the code more? maybe how to make use of objects and arrays more instead of using variables.