Open
Conversation
nd displaying the current round winner modified, keeping score added
Flashrob
reviewed
Oct 24, 2023
| determineLastRound = () => { | ||
| let numOfRoundsLeft = this.state.cardDeck.length / 2; | ||
| if (numOfRoundsLeft === 0) { | ||
| this.setState({ isItLastRound: true }); |
There was a problem hiding this comment.
Suggested change
| this.setState({ isItLastRound: true }); | |
| this.setState({ isLastRound: true }); |
Comment on lines
+84
to
+106
| const gameDirections = this.state.isItLastRound | ||
| ? `Click "Reset the game" to start a new game.` | ||
| : `Click "Deal" to draw cards.`; | ||
| const currRoundWinnerOutput = this.state.currRoundWinner | ||
| ? `Player ${this.state.currRoundWinner} won this round.` | ||
| : `It's a tie!`; | ||
| const playerOneNumOfWinsOutput = `Player 1 has ${this.state.playerOneNumOfWins} wins.`; | ||
| const playerTwoNumOfWinsOutput = `Player 2 has ${this.state.playerTwoNumOfWins} wins.`; | ||
|
|
||
| const numOfRoundsLeftOutput = `Number of rounds left: ${ | ||
| this.state.cardDeck.length / 2 | ||
| }`; | ||
| //logic to determine the game winner | ||
| let gameWinner = null; | ||
| if (this.state.playerOneNumOfWins > this.state.playerTwoNumOfWins) { | ||
| gameWinner = 1; | ||
| } | ||
| if (this.state.playerTwoNumOfWins > this.state.playerOneNumOfWins) { | ||
| gameWinner = 2; | ||
| } | ||
| const gameWinnerOutput = gameWinner | ||
| ? `Player ${gameWinner} won the game!` | ||
| : `It's a tie!`; |
There was a problem hiding this comment.
I am not exactly a fan of all these evaluations. I would rather use conditional rendering for these instead of storing all this in variables and redefining it constantly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.