-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #87
Documentation #87
Conversation
Thanks for working on this, can we add this for the Build Types & Flavors?
|
Also we can add this for the CI & CD:
|
- **Transitions** - [Material motion](https://github.com/material-components/material-components-android/blob/master/docs/theming/Motion.md#motion) transitions are used throughout the app. There are also examples of slide and grow ([shared element](https://developer.android.com/guide/fragments/animate#shared)) transitions between `MainFragment` and `SecondFragment`. | ||
- **Leak detection** - [LeakCanary](https://square.github.io/leakcanary/) is used for memory leak detection. | ||
- **Network traffic monitoring** - [Chucker](https://github.com/ChuckerTeam/chucker) is used for inspection of HTTP(S) requests/responses fired by this app. | ||
- **Logging** - [Timber](https://github.com/JakeWharton/timber) is used for logging to make sure that puppies live :) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add some brief of the Google Services that we are using:
- Google services: We use several of the most common Firebase services, such as crash reports, analytics, push notifications - we have several classes that allow us to customize the different channels and the behavior of notifications easily, Google Maps - We add some classes that allow us to quickly add points, draw routes, get directions and more.
We can also talk a bit about our architecture, right @brimanning ? Something like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I think this is looking good! I like Julian's recommendations as well, whether they're added as part of this PR or another.
I'll add Julian's recommendations as part of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @IvanToplak!
One Line Summary
Updating documentation.
Issue(s) Addressed
Referencing #74
Steps to Reproduce/Test
N/A
Checklist
N/A