Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type errors using pyright typeCheckingMode strict. #161

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fix type errors using pyright typeCheckingMode strict. #161

merged 2 commits into from
Dec 2, 2024

Conversation

Menziess
Copy link
Contributor

  • Use Optional[T] over Union[T, None]
  • Switch order or class definitions so that used classes are defined earlier in the code
  • Use from __future__ import annotations to fix references to classes or types that are defined later in the code
  • Added missing argument types

@Congyuwang
Copy link
Collaborator

Thanks!

@Congyuwang Congyuwang merged commit 22998b7 into rocksdict:main Dec 2, 2024
26 checks passed
@Menziess Menziess deleted the feature/pyright-typing-update branch December 2, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Menziess @Congyuwang