Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lxqt-session, enable start in sddm #580

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

Besanon
Copy link
Contributor

@Besanon Besanon commented Oct 24, 2024

No description provided.

first file for the LXQT 2.0 desktop group
starter file for LXQT Desktop
I use sddm as display manager

I cant remove the other file - only use graphical env., sorry

After startlxqt i would add  2 lines to sddm to enable the start of LXQT desktop
Enable sddm to start an lxqt desktop session
lxqt-session to be started by startlxqt. Display manager: sddm

ptrace (read),

network netlink raw,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule should come before the signal rules.

@{exec_path} = @{bin}/lxqt-session
profile lxqt-session @{exec_path} flags=(attach_disconnected) {
include <abstractions/base>
include <abstractions/dbus-accessibility>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use bus-accessibility instead (see https://apparmor.pujol.io/development/dbus/)

Comment on lines 50 to 51
@{bin}/python3.@{int} rPx,
@{lib}/python3.@{int} rPx,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is no profile for @{bin}/python3.@{int}
  • There is no such thing as an exec name: @{lib}/python3.@{int}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now i will remove this, yes. I used a different profile for python. Only applicable with some backup programs

Comment on lines 76 to 77
owner @{HOME}/.local/share/ r,
owner @{HOME}/.config/ r,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, they are included in lxqt

Comment on lines 78 to 79
owner @{HOME}/.config/autostart/ r,
owner @{HOME}/.config/autostart/* rw,
Copy link
Owner

@roddhjav roddhjav Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be:

  owner @{user_config_dirs}/autostart/ r,
  owner @{user_config_dirs}/autostart/*.desktop r,

owner @{user_cache_dirs}/openbox/sessions/ rw,
owner @{user_cache_dirs}/openbox/openbox.log rwk,
owner @{user_config_dirs}/mimeapps.list{,.@{rand6}} rw,
owner @{user_config_dirs}/dconf/user r,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, use the dconf abs instead.

owner @{user_config_dirs}/mimeapps.list{,.@{rand6}} rw,
owner @{user_config_dirs}/dconf/user r,
owner @{user_config_dirs}/openbox/rc.xml r,
owner @{user_share_dirs}/sddm/xorg-session.log rw,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, this is already part of X-strict

@{PROC}/@{pid}/stat r,
owner @{PROC}/@{pid}/stat r,

@{run}/systemd/inhibit/** rw,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be @{att}/@{run}/systemd/inhibit/@{int}.ref rw, and the rule should come before the @{PROC} ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt reflected this change, going to check the other profiles as well

include <abstractions/app/systemctl>

include if exists <local/lxqt-session_systemctl>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to close the systemctl subprofile: }


/dev/tty rw,

include if exists <local/lxqt-session>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please more this include after the subprofile (it is where we place it for all other profiles).

@roddhjav
Copy link
Owner

That should be good as a first version of the profile. Note that this part of lxqt is most likelly an app launcher. If so, you can remove all rPx rule and add include <abstractions/app-launcher-user>

@Besanon
Copy link
Contributor Author

Besanon commented Oct 25, 2024

which profile is supposed to be an app-launcher has been a bit confusing in the past. I will try to change this in lxqt-session, see if its ok to entirely remove the singel rPx-calls

@Besanon
Copy link
Contributor Author

Besanon commented Oct 25, 2024

well, i added
include <abstractions/app-launcher-user>
it is now in lxqt-session and lxqt-panel. I am not sure about which programs still need to be called via rPx. There are some. Maybe not all are reflected in the changes. But it is working. Have a look

is needed for several complaints:
DENIED  kscreen_backend_launcher open owner @{user_config_dirs}/lxqt/lxqt.conf comm=kscreen_backend requested_mask=r denied_mask=r
DENIED  kscreen_backend_launcher open /usr/share/lxqt/lxqt.conf comm=kscreen_backend requested_mask=r denied_mask=r
DENIED  kscreen_backend_launcher open owner @{user_config_dirs}/lxqt/session.conf comm=kscreen_backend requested_mask=r denied_mask=r
DENIED  kscreen_backend_launcher open /usr/share/lxqt/session.conf comm=kscreen_backend requested_mask=r denied_mask=r
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants