fix: remove event aggregate in email

rodekruis · Oct 17, 2024 · 2c4117e · 2c4117e
1 parent 1088ba8
commit 2c4117e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 31 deletions.
diff --git a/services/API-service/src/api/notification/email/mjml.service.ts b/services/API-service/src/api/notification/email/mjml.service.ts
@@ -83,9 +83,7 @@ export class MjmlService {
 
     children.push(this.mailOpening);
 
-    children.push(
-      ...getMjmlEventListBody(emailContent, this.helperService.toCompactNumber),
-    );
+    children.push(...getMjmlEventListBody(emailContent));
 
     children.push(
       this.notificationAction({

diff --git a/services/API-service/src/api/notification/email/mjml/body-event.ts b/services/API-service/src/api/notification/email/mjml/body-event.ts
@@ -1,4 +1,3 @@
-import { NumberFormat } from '../../../../shared/enums/number-format.enum';
 import { ContentEventEmail } from '../../dto/content-trigger-email.dto';
 import { TriggerStatusLabelEnum } from '../../dto/notification-date-per-event.dto';
 import {
@@ -23,15 +22,12 @@ const getMjmlBodyEvent = ({
   firstLeadTimeString,
   firstTriggerLeadTimeFromNow,
   firstTriggerLeadTimeString,
-  indicatorLabel,
   issuedDate,
   nrOfTriggeredAreas,
   timeZone,
-  totalAffected,
   triangleIcon,
   eapLink,
   triggerStatusLabel,
-  toCompactNumberWithFormat,
 }: {
   color: string;
   defaultAdminAreaLabel: string;
@@ -42,15 +38,12 @@ const getMjmlBodyEvent = ({
   firstLeadTimeString: string;
   firstTriggerLeadTimeFromNow: string;
   firstTriggerLeadTimeString: string;
-  indicatorLabel: string;
   issuedDate: string;
   nrOfTriggeredAreas: number;
   timeZone: string;
-  totalAffected: number;
   triangleIcon: string;
   eapLink: string;
   triggerStatusLabel: string;
-  toCompactNumberWithFormat: (value: number) => string;
 }): object => {
   const icon = getInlineImage({ src: triangleIcon, size: 16 });
 
@@ -82,14 +75,7 @@ const getMjmlBodyEvent = ({
 
   contentContent.push(
     `<strong>Expected exposed ${defaultAdminAreaLabel}:</strong> ${nrOfTriggeredAreas} (see list below)`,
-  ),
-    contentContent.push(
-      `<strong>${indicatorLabel}:</strong> ${
-        totalAffected
-          ? `Approximately ${toCompactNumberWithFormat(totalAffected)}`
-          : 'Information is unavailable'
-      }`,
-    );
+  );
 
   contentContent.push(
     triggerStatusLabel === TriggerStatusLabelEnum.Trigger
@@ -115,10 +101,7 @@ const getMjmlBodyEvent = ({
   });
 };
 
-export const getMjmlEventListBody = (
-  emailContent: ContentEventEmail,
-  toCompactNumber: (value: number, format: NumberFormat) => string,
-): object[] => {
+export const getMjmlEventListBody = (emailContent: ContentEventEmail) => {
   const eventList = [];
 
   for (const event of emailContent.dataPerEvent) {
@@ -145,15 +128,6 @@ export const getMjmlEventListBody = (
         defaultAdminAreaLabel:
           emailContent.defaultAdminAreaLabel.plural.toLocaleLowerCase(),
 
-        // Indicator details
-        indicatorLabel: emailContent.indicatorMetadata.label,
-        totalAffected: event.totalAffectedOfIndicator,
-        toCompactNumberWithFormat: (value: number) =>
-          toCompactNumber(
-            value,
-            emailContent.indicatorMetadata.numberFormatMap,
-          ),
-
         // EAP details
         triangleIcon: getTriangleIcon(
           event.eapAlertClass?.key,