update Go, fix, add /@latest to goproxytest#302
Open
mvdan wants to merge 3 commits intorogpeppe:masterfrom
Open
update Go, fix, add /@latest to goproxytest#302mvdan wants to merge 3 commits intorogpeppe:masterfrom
mvdan wants to merge 3 commits intorogpeppe:masterfrom
Conversation
Mainly so that gopls is not as noisy when editing files.
The Go module proxy protocol defines a $base/$module/@latest endpoint that returns the .info JSON for the latest version of a module. The handler only matched paths containing /@v/, so /@latest got a 404. Add a check for the /@latest suffix before the /@v/ routing. When matched, find the highest semver version (skipping pseudo-versions) and serve its .info file. The test is a direct HTTP unit test rather than a testscript like testdata/list.txt because the go command does not expose /@latest responses to the user; it uses the endpoint internally as a fallback. There is no go subcommand whose output we could assert on in a script to verify that /@latest is served correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)