-
-
Notifications
You must be signed in to change notification settings - Fork 118
Add video spotlight effect #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
awasthi108
wants to merge
7
commits into
rohitdasu:main
Choose a base branch
from
awasthi108:add-video-spotlight-effect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a minimal, non-intrusive mouse tracker dot that follows the cursor across all pages. The component: - Is globally available across all pages - Uses theme colors and respects dark/light modes - Doesn't interfere with user interactions - Cleans up event listeners properly - Is accessible and performance-optimized
This commit adds an immersive spotlight effect to the video demo section: - Dims the surrounding content when video is in view - Smooth transitions for better user experience - Maintains accessibility and performance - No interference with user interactions - Proper cleanup on unmount The feature enhances the demo video viewing experience by: - Drawing focus to the video content - Creating a theater-like experience - Using non-intrusive animations - Preserving all existing functionality
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hi @awasthi108, could you attach any screenshot here in the PR description? thanks. |
Now i see, cool feature. Could you please resolve conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video Demo Spotlight Effect Enhancement
Description
Added an immersive spotlight effect to the video demo section that dims surrounding content when the video comes into view, creating a more focused and engaging user experience.
Features
Implementation Details
Testing Done
Screenshots/GIFs
[It would be good to add screenshots or GIFs showing the effect in action]
Type of Change
Checklist
Additional Notes
This enhancement aims to improve the user experience when viewing the project demo video without compromising on performance or accessibility. The implementation is lightweight and maintains all existing functionality while adding an engaging visual effect.