Fix EINVAL crash (#82)

* Fix EINVAL crash * Set windowsHide: true to hide child process terminal windows * Update spawnAsync Unit Test --------- Co-authored-by: Bronley Plumb <bronley@gmail.com>
rokucommunity · Dec 23, 2024 · 8863439 · 8863439
1 parent 41ae628
commit 8863439
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/util.spec.ts b/src/util.spec.ts
@@ -81,7 +81,7 @@ describe('Util', () => {
             });
             await util.spawnAsync('noop');
             expect(stub.getCalls()[0].args).to.eql([
-                'noop', [], { stdio: 'inherit' }
+                'noop', [], { stdio: 'inherit', shell: true, windowsHide: true }
             ]);
         });
     });

diff --git a/src/util.ts b/src/util.ts
@@ -24,7 +24,9 @@ export class Util {
         return new Promise((resolve, reject) => {
             const child = childProcess.spawn(command, args ?? [], {
                 ...(options ?? {}),
-                stdio: 'inherit'
+                stdio: 'inherit',
+                shell: true,
+                windowsHide: true
             });
             child.addListener('error', reject);
             child.addListener('exit', resolve);