Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vue 3 example #1115

Merged
1 commit merged into from
Aug 1, 2023
Merged

Add Vue 3 example #1115

1 commit merged into from
Aug 1, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 31, 2023

Description of the change

Added Vue 3 integration example

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@ghost ghost requested review from waltjones and mudetroit July 31, 2023 19:19
mudetroit
mudetroit approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Vue is rusty but this looks reasonable enough

@ghost ghost merged commit b839c09 into master Aug 1, 2023
5 checks passed
@ghost ghost deleted the bborsits/vue-js-example branch August 1, 2023 12:01
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
Merge pull request #1115 from rollbar/bborsits/vue-js-example
ca03495 
Add Vue 3 example
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones Awaiting requested review from waltjones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mudetroit