Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 8 support #1119

Merged
merged 11 commits into from
Sep 29, 2023
Merged
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
node-version: [8, 10, 12, 14, 16]
node-version: [10, 12, 14, 16]

steps:
- uses: actions/checkout@v2
Expand Down
36 changes: 3 additions & 33 deletions Gruntfile.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
/**
* Build and test rollbar.js
*
* Test with browserstack:
* $> BROWSER_STACK_USERNAME=username BROWSER_STACK_ACCESS_KEY=12345asdf grunt test --browsers=bs_ie_latest
*
*/


Expand All @@ -15,7 +11,6 @@ var pkg = require('./package.json');
var fs = require('fs');

var webpackConfig = require('./webpack.config.js');
var browserStackBrowsers = require('./browserstack.browsers');


function findTests(context) {
Expand All @@ -33,7 +28,7 @@ function findTests(context) {
return mapping;
}

function buildGruntKarmaConfig(singleRun, browsers, tests, reporters) {
function buildGruntKarmaConfig(singleRun, tests, reporters) {
var config = {
options: {
configFile: './karma.conf.js',
Expand Down Expand Up @@ -71,10 +66,6 @@ function buildGruntKarmaConfig(singleRun, browsers, tests, reporters) {
},
};

if (browsers && browsers.length) {
config.options.browsers = browsers;
}

if (reporters && reporters.length) {
config.options.reporters = reporters;
}
Expand Down Expand Up @@ -112,27 +103,6 @@ module.exports = function(grunt) {
require('time-grunt')(grunt);

var browserTests = findTests('browser');
var browsers = grunt.option('browsers');
if (browsers) {
browsers = browsers.split(',');

var browserStackAliases = [];
var nonBrowserStackAliases = [];
browsers.forEach(function(browserName) {
if (browserName.slice(0, 3) === 'bs_') {
browserStackAliases.push(browserName);
} else {
nonBrowserStackAliases.push(browserName);
}
});

var expandedBrowsers = browserStackBrowsers.filter.apply(null, browserStackAliases);
var expandedBrowserNames = [];
expandedBrowsers.forEach(function(browser) {
expandedBrowserNames.push(browser._alias);
});
browsers = nonBrowserStackAliases.concat(expandedBrowserNames);
}

var singleRun = grunt.option('singleRun');
if (singleRun === undefined) {
Expand Down Expand Up @@ -165,7 +135,7 @@ module.exports = function(grunt) {
}
},

karma: buildGruntKarmaConfig(singleRun, browsers, browserTests, reporters),
karma: buildGruntKarmaConfig(singleRun, browserTests, reporters),

replace: {
snippets: {
Expand All @@ -188,7 +158,7 @@ module.exports = function(grunt) {
return captures.join('\n');
}
},
// README travis link
// README CI link
{
from: new RegExp('(https://github\\.com/rollbar/rollbar\\.js/workflows/Rollbar\\.js%20CI/badge\\.svg\\?branch=v)([0-9a-zA-Z.-]+)'),
to: function(match, index, fullText, captures) {
Expand Down
153 changes: 0 additions & 153 deletions browserstack.browsers.js

This file was deleted.

Loading
Loading