Don't look for for non-top frame locals in node >=18 during locals tests #1134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Post-merge comment
Locals seem to be available after all but changes in how Node 18 deliver call frames has broken our mechanism to extract these.
This is now a bug, and we should be able to revert these changes once we figure out how to extract locals for Node 18+.
Refer to ticket SC-134017.
Description of the change
This PR fixes a failing test running over false assumptions around node/v8 locals in stack traces.
After careful testing, beginning Node.js 18, it seems locals are only present in top frames. However, I wasn't able to pinpoint documentation about this.
Note
This PR also updates CI to run installs and tests under lts nodes 14 through latest.
Type of change
Checklists
Development
Code review