Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look for for non-top frame locals in node >=18 during locals tests #1134

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

matux
Copy link
Contributor

@matux matux commented Mar 7, 2024

Important

Post-merge comment

Locals seem to be available after all but changes in how Node 18 deliver call frames has broken our mechanism to extract these.

This is now a bug, and we should be able to revert these changes once we figure out how to extract locals for Node 18+.

Refer to ticket SC-134017.

Description of the change

This PR fixes a failing test running over false assumptions around node/v8 locals in stack traces.

After careful testing, beginning Node.js 18, it seems locals are only present in top frames. However, I wasn't able to pinpoint documentation about this.

Note

This PR also updates CI to run installs and tests under lts nodes 14 through latest.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Mar 7, 2024
Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matux matux merged commit 04e15e0 into master Mar 7, 2024
5 checks passed
@matux matux deleted the matux/locals branch March 7, 2024 14:52
Copy link

mudetroit pushed a commit that referenced this pull request Mar 14, 2024
Don't look for for non-top frame locals in node >=18 during locals tests
Update CI to test lts nodes from 14 through 20 and non-lts 21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants