fix: Handle the formatting of array arguments #1139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
We are using
rollbar.js
in our application, and because of internal monkey-patching ofconsole.warn
some instances of invariants triggered byapollo-client
crash rollbar and our application as a result.When
apollo-client
logs those invariants viaconsole.warn
it has some of the arguments specified as array of objects, which get through theformatArgsAsString
inside rollbar, which does not really handle arrays anyhow and crashes.This change adds graceful handling of the arrays via a simple recursive call, trimming the array to the first 10 items not to cause any significant overhead on processing.
Type of change
Related issues
Checklists
Development
Code review