-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Docker instructions #57
Clean up Docker instructions #57
Conversation
@HCastano thanks for the contribution! |
26657 is for celestia-app in this setup https://docs.celestia.org/nodes/celestia-app/#ports |
@jcstein are the ports documented anywhere? which port is for which purpose? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcstein The Celestia docs don't explain the difference between 26657 and 26658 though. Even in the troubleshooting docs the the text body mentions *57 while the table has info for *58 🤷♂️ Personally, my attempts to use port *57 for JSON-RPC requests fail, so I image there must be some difference. |
to clarify, the troubleshooting page is for celestia-node 26658 is RPC for celestia-node (JSON-RPC) https://docs.celestia.org/nodes/celestia-node-troubleshooting/#ports 26657 is RPC for celestia-app https://docs.celestia.org/nodes/celestia-app/#ports |
it sounds like a Celestia-wide description of different ports would make sense both in this readme and in celestia docs |
@jcstein gotcha, didn't realize they were for different node types. I've added a column with the node type for each port, let me know what you think |
amazing! thank you again for the PR and contribution @HCastano 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! :) |
Hey! I ended up running into an couple of issues when using the provided Docker command
since it was using a) an old version of the Celestia node and b) not forwarding the port
used by the JSON-RPC API.
I've updated the README accordingly.
On a sidenote, what's the difference between port 26657 and 26658. In the docs it says
both are for RPC but I don't see 26657 used anywhere.
Thanks!