Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Docker instructions #57

Merged
merged 9 commits into from
Aug 2, 2023
Merged

Clean up Docker instructions #57

merged 9 commits into from
Aug 2, 2023

Conversation

HCastano
Copy link
Contributor

Hey! I ended up running into an couple of issues when using the provided Docker command
since it was using a) an old version of the Celestia node and b) not forwarding the port
used by the JSON-RPC API.

I've updated the README accordingly.


On a sidenote, what's the difference between port 26657 and 26658. In the docs it says
both are for RPC but I don't see 26657 used anywhere.

Thanks!

README.md Outdated Show resolved Hide resolved
@MSevey
Copy link
Contributor

MSevey commented Jul 31, 2023

@HCastano thanks for the contribution!

@MSevey MSevey requested review from gupadhyaya and jcstein and removed request for Bidon15 and tty47 July 31, 2023 13:13
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jcstein
Copy link
Member

jcstein commented Jul 31, 2023

On a sidenote, what's the difference between port 26657 and 26658. In the docs it says
both are for RPC but I don't see 26657 used anywhere.

26657 is for celestia-app in this setup https://docs.celestia.org/nodes/celestia-app/#ports

@MSevey
Copy link
Contributor

MSevey commented Jul 31, 2023

@jcstein are the ports documented anywhere? which port is for which purpose?
Even though it might be duplication, I think it is worthwhile also documenting in this repo why we are using the ports we do.

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HCastano would you like to add a piece about the different ports used here? you can find the details in celestia docs here and here

thank you for your contribution and please let me know if you need help (or want me to add that bit)

@HCastano
Copy link
Contributor Author

@jcstein The Celestia docs don't explain the difference between 26657 and 26658 though. Even in the troubleshooting docs the the text body mentions *57 while the table has info for *58 🤷‍♂️

Personally, my attempts to use port *57 for JSON-RPC requests fail, so I image there must be some difference.

@jcstein
Copy link
Member

jcstein commented Jul 31, 2023

to clarify, the troubleshooting page is for celestia-node

26658 is RPC for celestia-node (JSON-RPC) https://docs.celestia.org/nodes/celestia-node-troubleshooting/#ports

26657 is RPC for celestia-app https://docs.celestia.org/nodes/celestia-app/#ports

@jcstein
Copy link
Member

jcstein commented Jul 31, 2023

it sounds like a Celestia-wide description of different ports would make sense both in this readme and in celestia docs

@HCastano
Copy link
Contributor Author

HCastano commented Aug 1, 2023

@jcstein gotcha, didn't realize they were for different node types. I've added a column with the node type for each port, let me know what you think

@jcstein
Copy link
Member

jcstein commented Aug 1, 2023

amazing! thank you again for the PR and contribution @HCastano 😄

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jcstein jcstein enabled auto-merge (squash) August 1, 2023 16:20
@jcstein jcstein merged commit ed46fdb into rollkit:main Aug 2, 2023
3 checks passed
@nashqueue
Copy link
Member

Thank you for your contribution! :)

@HCastano HCastano deleted the hc-clean-up-docker-readme-instructions branch August 3, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants