Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Support for ssh-certificates #477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Senjuu
Copy link

@Senjuu Senjuu commented Feb 17, 2024

Hallo romanz,
I recently found an error from my first merge-request (#373) as I did the requested rebase and squash. So I am now posting the missing changes.

@Senjuu Senjuu force-pushed the fix-sign-certificate branch 9 times, most recently from f0534ef to 4f5db51 Compare February 17, 2024 16:54
@romanz romanz self-requested a review February 18, 2024 08:23
res['public_key'] = formats.parse_pubkey(public_key)
_certificate = certificate.parse(data)
if _certificate['isCertificate']:
certificate.format(_certificate)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no format() defined in libagent.ssh.certificate module.

It produces the following error:

Traceback (most recent call last):
  File "/XYZ/lib/python3.10/site-packages/libagent/server.py", line 103, in handle_connection
    reply = handler.handle(msg=msg)
  File "/XYZ/lib/python3.10/site-packages/libagent/ssh/protocol.py", line 106, in handle
    reply = method(buf=buf)
  File "/XYZ/lib/python3.10/site-packages/libagent/ssh/protocol.py", line 147, in sign_message
    signature = self.conn.sign(blob=blob, identity=key['identity'])
  File "/XYZ/lib/python3.10/site-packages/libagent/ssh/__init__.py", line 279, in sign
    return conn.sign_ssh_challenge(blob=blob, identity=identity)
  File "/XYZ/lib/python3.10/site-packages/libagent/ssh/client.py", line 35, in sign_ssh_challenge
    msg = parse_ssh_blob(blob)
  File "/XYZ/lib/python3.10/site-packages/libagent/ssh/client.py", line 80, in parse_ssh_blob
    certificate.format(_certificate)
AttributeError: module 'libagent.ssh.certificate' has no attribute 'format'

@Senjuu Senjuu force-pushed the fix-sign-certificate branch 3 times, most recently from 3a2f141 to f710988 Compare March 19, 2024 18:08
@Senjuu
Copy link
Author

Senjuu commented Mar 19, 2024

As I removed some private modifications that I do not recommend for public use I seem to have removed one to many function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants