Cleanup & fix shell-quoting in generated 'env' and 'run-agent.sh' scripts #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipts * Fix shell-quoting of arguments in .gnupg/trezor/`env` and .gnupg/trezor/`run-agent.sh` for non-Windows platforms. * Fix `AttributeError: 'float' object has no attribute 'translate'` when passing --cache-expiry-seconds to `*-gpg init` on all platforms. * Add "exec" to the sh scripts, where appropriate, so that the wrapped command replaces the shell, rather than running in a subprocess. * Move Bourne sh and Windows batch-file templates into separate sections of code, since it doesn't make sense to combine them once we're doing quoting properly. * Use standard POSIX /bin/sh syntax in the env script so that this has the possibility of working on systems without /bin/bash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix shell-quoting of arguments in .gnupg/trezor/
envand .gnupg/trezor/run-agent.shfor non-Windows platforms.Fix
AttributeError: 'float' object has no attribute 'translate'when passing --cache-expiry-seconds to*-gpg initon all platforms.Add "exec" to the sh scripts, where appropriate, so that the wrapped command replaces the shell, rather than running in a subprocess.
Move Bourne sh and Windows batch-file templates into separate sections of code, since it doesn't make sense to combine them once we're doing quoting properly.
Use standard POSIX /bin/sh syntax in the env script so that this has the possibility of working on systems without /bin/bash.