Adds a headerItem property in case a header is desired for the menu#84
Open
vittoriom wants to merge 3 commits intoromaonthego:masterfrom
Open
Adds a headerItem property in case a header is desired for the menu#84vittoriom wants to merge 3 commits intoromaonthego:masterfrom
vittoriom wants to merge 3 commits intoromaonthego:masterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The headerItem is just a REMenuItem so it's very easy to create one. Moreover, it's just a property on the REMenu instance and it's back-compatible with the existing codebase since when no header is specified, the normal behavior is preserved.
I removed the combinedHeight computed property in favour of a manually set one (this could open the road to different heights for each menuItem - maybe through a dataSource protocol)