UIScrollView to scroll items if not fit to the screen#88
Open
itimofeev wants to merge 2 commits intoromaonthego:masterfrom
itimofeev:master
Open
UIScrollView to scroll items if not fit to the screen#88itimofeev wants to merge 2 commits intoromaonthego:masterfrom itimofeev:master
itimofeev wants to merge 2 commits intoromaonthego:masterfrom
itimofeev:master
Conversation
…ll when items not fit to the screen
|
+1 |
Owner
|
Good idea, but it looks like there are some issues with the scroll view height, it goes below the screen. |
…ll when items not fit to the screen
Author
|
Fixed scroll view height. Tested in ios 6,7,8 with navigation bar. |
|
+1 |
|
@itimofeev Nice job. but..
You have removed |
|
Has anyone else run into the issue where the menu no longer recognizes taps or clicks and only allows swipe gestures for selecting a menu item? |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this nice library!
But we used it to show dynamically loaded from server list of actions and sometimes this list is very long so not fit to the screen. Now we can scroll this list to get to last action for example.
Technically UIView with REMenuItemViews replaced with UIScrollView to be able to scroll when items not fit to the screen.