Fixed nav bar offset calculation when status bar is hidden#92
Open
ayn wants to merge 14 commits intoromaonthego:masterfrom
Open
Fixed nav bar offset calculation when status bar is hidden#92ayn wants to merge 14 commits intoromaonthego:masterfrom
ayn wants to merge 14 commits intoromaonthego:masterfrom
Conversation
…ll when items not fit to the screen
…ll when items not fit to the screen
Conflicts: REMenu/REMenu.m
|
@ayn, you should squash your commits for this work. Also, it seems like this PR contains more changes than just the status bar change. Why is REMenuContainerView deleted? |
Author
|
@mmdole been a while, but it's because it’s now using a plain |
Author
|
@mmcdole ^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the status bar is hidden, the top of menu had an extra 20 pts of space. This fixes the navigationBarOffset calculation when status bar is hidden.