Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Poetry support to virtualenv #2450

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add Poetry support to virtualenv #2450

wants to merge 13 commits into from

Commits on Oct 12, 2023

  1. Document some logic in prompt_virtualenv()

    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    ffc1f17 View commit details
    Browse the repository at this point in the history

  2. Add Poetry support to virtualenv 

    Heavily based on romkatv#1994.

Integrate Poetry virtualenv detection into the existing virtualenv
segment. For poetry virtualenvs, use the package name as reported by
`poetry version`.
    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e3e5605 View commit details
    Browse the repository at this point in the history

  3. Remove POWERLEVEL9K_VIRTUALENV_ENABLE_POETRY 

    Added for debugging purposes.
    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a79a934 View commit details
    Browse the repository at this point in the history

  4. Fix up function return value passing 

    Don't use echo, instead set a variable which the calling function
checks. This is the standard in p10, presumably because it's faster..?
    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e162e2a View commit details
    Browse the repository at this point in the history

  5. cosmetics

    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    db4b650 View commit details
    Browse the repository at this point in the history

  6. Try to cache poetry command

    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c10e62a View commit details
    Browse the repository at this point in the history

  7. fixup! Fix up function return value passing

    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    414c330 View commit details
    Browse the repository at this point in the history

  8. Improve function names 

    Make them a little less ambiguous.
    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8608896 View commit details
    Browse the repository at this point in the history

  9. Fix cleanup of generic virtualenv names

    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    fe9b9f9 View commit details
    Browse the repository at this point in the history

  10. Fix POWERLEVEL9K_VIRTUALENV_SHOW_WITH_PYENV=if-different (I think) 

    We were comparing virtualenv's name to pyenv's version, which would
never be the same.

Now this setting works as intended, although I'm not sure how useful it
is. It's probably more useful to reorder this logic so virtualenv has
precedence.
    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    893e130 View commit details
    Browse the repository at this point in the history

  11. Correct caching for pyproject.toml

    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7e835be View commit details
    Browse the repository at this point in the history

  12. virtualenv: Handle not being in a virtualenv 

    Pre-Poetry support, we only entered this codepath when we were inside a
virtualenv. Now we enter it for every directory, but we don't want to
display an empty segment for non-virtualenv locations.
    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f2772bd View commit details
    Browse the repository at this point in the history

  13. Add error handling for poetry cmd

    @alexjurkiewicz
    alexjurkiewicz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    81c474c View commit details
    Browse the repository at this point in the history